Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to storybook v7 #1877

Closed
wants to merge 1 commit into from
Closed

upgrade to storybook v7 #1877

wants to merge 1 commit into from

Conversation

Rajdeepc
Copy link
Collaborator

@Rajdeepc Rajdeepc commented May 17, 2023 •
edited
Loading

Description

Update from Storybook v6 to Storybook v7

How and where has this been tested?

  • How this was tested:
    yarn build:preview
    yarn start
  • Browser(s) and OS(s) this was tested with:
    Chrome and Mac OSX

Screenshots

Please see ChangeLog

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have tested these changes in Windows High Contrast mode.
  • I have updated any relevant storybook stories and templates.
  • If my change(s) include visual change(s), a designer has reviewed and approved those changes.
  • This pull request is ready to merge.

@Rajdeepc Rajdeepc added documentation Because documentation is important and shouldn't be broken dependencies Pull requests that update a dependency file enhancement A request to add a feature to a component wip This is a work in progress, don't judge. labels May 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2023 •
edited
Loading

🚀 Deployed on https://pr-1877--spectrum-css.netlify.app

@github-actions github-actions bot temporarily deployed to pull request May 22, 2023 14:34 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 22, 2023 18:52 Inactive
@pfulton pfulton mentioned this pull request May 22, 2023
Closed
@github-actions github-actions bot temporarily deployed to pull request May 23, 2023 07:02 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 23, 2023 08:08 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 23, 2023 09:54 Inactive
@Rajdeepc Rajdeepc marked this pull request as ready for review May 23, 2023 12:33
@Rajdeepc Rajdeepc added storybook breaking change Results in a breaking API change and removed dependencies Pull requests that update a dependency file wip This is a work in progress, don't judge. labels May 23, 2023
@github-actions github-actions bot temporarily deployed to pull request May 23, 2023 12:41 Inactive
castastrophe
castastrophe requested changes May 23, 2023
View reviewed changes
components/accordion/stories/accordion.stories.js Outdated Show resolved Hide resolved
tools/preview/main.js Outdated Show resolved Hide resolved
tools/preview/package.json Outdated Show resolved Hide resolved
tools/preview/preview.js Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request May 23, 2023 15:10 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 23, 2023 16:49 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 24, 2023 18:40 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 26, 2023 21:18 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 29, 2023 11:00 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 29, 2023 11:16 Inactive
@Rajdeepc
Copy link
Collaborator Author

Open Bugs: Page is refreshing on changing routes quickly.
webpack/webpack#15541
storybookjs/storybook#22706

@Rajdeepc Rajdeepc marked this pull request as draft May 29, 2023 13:07
@Rajdeepc
Copy link
Collaborator Author

Rajdeepc commented Jun 2, 2023

Open Bugs: Page is refreshing on changing routes quickly. webpack/webpack#15541 storybookjs/storybook#22706

I see these issues in a simple Storybook project also. So its evident it is not coming from our codebase. I had a discussion on this on discord and someone from the Storybook team is looking into it. It might be some conflicting webpack5 settings.
Though I am testing all the components but the PR is ready for review. I would love to get some feedback and suggestions.

@Rajdeepc Rajdeepc removed the breaking change Results in a breaking API change label Jun 2, 2023
@github-actions github-actions bot temporarily deployed to pull request June 2, 2023 13:30 Inactive
@castastrophe castastrophe force-pushed the upgrade/storybook-latest branch 2 times, most recently from 717cc99 to 34389b4 Compare June 2, 2023 13:36
@github-actions github-actions bot temporarily deployed to pull request June 2, 2023 13:46 Inactive
castastrophe
castastrophe approved these changes Jun 2, 2023
View reviewed changes
Copy link
Collaborator

@castastrophe castastrophe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated this locally and in compiled result and it's looking great. Able to move between stories and toggle contexts easily. Documentation makes sense & is working also. Assets are loading correctly.

@github-actions github-actions bot temporarily deployed to pull request June 2, 2023 14:10 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 5, 2023 05:43 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 12, 2023 16:54 Inactive
@pfulton pfulton added the run_vrt For use on PRs looking to kick off VRT label Jun 12, 2023
@github-actions github-actions bot removed the run_vrt For use on PRs looking to kick off VRT label Jun 12, 2023
@github-actions github-actions bot temporarily deployed to pull request June 12, 2023 19:30 Inactive
@pfulton pfulton added the run_vrt For use on PRs looking to kick off VRT label Jun 12, 2023
@github-actions github-actions bot removed the run_vrt For use on PRs looking to kick off VRT label Jun 12, 2023
@github-actions github-actions bot temporarily deployed to pull request June 12, 2023 20:59 Inactive
@pfulton pfulton added the run_vrt For use on PRs looking to kick off VRT label Jun 12, 2023
@github-actions github-actions bot temporarily deployed to pull request June 12, 2023 21:34 Inactive
@github-actions github-actions bot removed the run_vrt For use on PRs looking to kick off VRT label Jun 12, 2023
@pfulton pfulton marked this pull request as draft June 12, 2023 21:37
@pfulton pfulton added the do not merge A flag for a branch indicating it should not be merged. label Jun 12, 2023
@pfulton
Copy link
Collaborator

pfulton commented Jun 12, 2023 •
edited
Loading

We might close this in favor of #1935

@pfulton pfulton closed this Jun 13, 2023
@pfulton pfulton deleted the upgrade/storybook-latest branch June 13, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@castastrophe castastrophe castastrophe approved these changes

@pfulton pfulton Awaiting requested review from pfulton

Assignees
No one assigned
Labels
do not merge A flag for a branch indicating it should not be merged. documentation Because documentation is important and shouldn't be broken enhancement A request to add a feature to a component storybook
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rajdeepc @pfulton @castastrophe