Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless PHPUnit versions definition #5

Merged
merged 1 commit into from
Mar 8, 2019

Conversation

peter279k
Copy link
Collaborator

Introduction

  • It's about removing useless PHPUnit versions in composer.json.
  • This package requires php-7.0 version at least and the PHPUnit version should be 6.x at least.
    And it's fine to remove useless PHPUnit versions definition in composer.json.
  • General improvement

@codecov-io
Copy link

codecov-io commented Mar 5, 2019

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             master    #5    /-   ##
======================================
  Coverage        40%   40%           
  Complexity       11    11           
======================================
  Files             1     1           
  Lines            25    25           
======================================
  Hits             10    10           
  Misses           15    15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a6961a...5a22846. Read the comment docs.

Copy link
Owner

@adhocore adhocore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@adhocore adhocore merged commit 13ef3a3 into adhocore:master Mar 8, 2019
@peter279k peter279k deleted the enhance_require_dev branch March 8, 2019 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants