Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance tests #1

Merged
merged 1 commit into from
Feb 27, 2019
Merged

Enhance tests #1

merged 1 commit into from
Feb 27, 2019

Conversation

peter279k
Copy link
Collaborator

Introduction

This is a

  • General improvement

Describe the change

  • Initialize the tests for the Asserts class.
  • Fix the sample code on README because the use namespace name is incorrect.

@codecov-io
Copy link

codecov-io commented Feb 27, 2019

Codecov Report

Merging #1 into master will increase coverage by 100%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #1      /-   ##
=========================================
  Coverage         0%   100%    100%     
  Complexity        3      3             
=========================================
  Files             1      1             
  Lines            10     10             
=========================================
  Hits              0     10      10     
  Misses           10      0     -10
Impacted Files Coverage Δ Complexity Δ
src/Asserts.php 100% <0%> ( 100%) 3% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5114b2a...0521b1c. Read the comment docs.

Copy link
Owner

@adhocore adhocore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much :)
i have more assertions coming if you are interested

@adhocore adhocore merged commit ea7f0d6 into adhocore:master Feb 27, 2019
@adhocore
Copy link
Owner

@peter279k it is nice to see you contributing once again. thank you.

the new assertions added are: https://github.com/adhocore/asserts/blob/master/src/Asserts.php#L37-L65

@peter279k peter279k deleted the enhance_stuffs branch March 5, 2019 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants