Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More protocol docs and adjust program according to specs #9

Merged
merged 4 commits into from
Sep 6, 2019
Merged

More protocol docs and adjust program according to specs #9

merged 4 commits into from
Sep 6, 2019

Conversation

eni23
Copy link
Contributor

@eni23 eni23 commented Sep 6, 2019

No description provided.

@eni23 eni23 requested a review from fujexo September 6, 2019 13:39
@fujexo fujexo assigned eni23 and unassigned fujexo Sep 6, 2019
fujexo
fujexo suggested changes Sep 6, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
hugenduebel
hugenduebel requested changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@hugenduebel hugenduebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix them grammars on line 128

fujexo
fujexo approved these changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@fujexo fujexo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hugenduebel
Copy link
Contributor

lookin' good

@hugenduebel hugenduebel merged commit 12ccbfe into adfinis:master Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugenduebel hugenduebel hugenduebel requested changes

@fujexo fujexo fujexo approved these changes

Assignees

@eni23 eni23

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eni23 @hugenduebel @fujexo @eni