This repository has been archived by the owner on Sep 18, 2019. It is now read-only.
Only add specific assets (app.css/.js) plus .DS_Store to gitignore #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It could be handy to add some static assets or other vendor files in
/public/cssand/public/js. Sure the ideal way shouldn't be that path, but in some cases there are valid reasons.Excluding the whole path wouldn't make that possible, so I replaced them with the
app.cssandapp.jsfiles according to the mix config.Additionally I've added
.DS_Store. Clearing the git cache and readding everything (e.g. a gitignore update), would add these files if they aren't ignored in the global config. Personally, I always forget that, so sometimes I end up with them in my repository. Since they don't harm in any gitignore, they're also added in this PR.