Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coding standards v3 #70

Merged
merged 18 commits into from
Jul 10, 2024
Merged

Coding standards v3 #70

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift click to select a range
b4bef3b
Coding standards v3
danepowell Jul 1, 2024
63b4b46
fix standards
danepowell Jul 2, 2024
5e243bc
fix tests
danepowell Jul 2, 2024
1c884ee
Apply suggestions from code review
danepowell Jul 3, 2024
56f750d
remove rogue drupalpractice sniff
danepowell Jul 3, 2024
a426441
allow throws
danepowell Jul 3, 2024
80ac3a4
Grammar niggle.
TravisCarden Jul 8, 2024
9165867
alphabetize standards
danepowell Jul 8, 2024
d37f9ce
remove Edge
danepowell Jul 8, 2024
a229fa5
psr-12 comment comment
danepowell Jul 8, 2024
e8271b5
Spacing niggle.
TravisCarden Jul 9, 2024
e1dd263
Rename AcquiaPHP and AcquiaDrupal to AcquiaPHPMinimal and AcquiaDrupa…
danepowell Jul 9, 2024
5829fde
Add comment
danepowell Jul 9, 2024
3a9f620
allow package annotation
danepowell Jul 9, 2024
6eb2c86
Update Composer branch alias.
TravisCarden Jul 9, 2024
f7a666d
Fix missed artifact of renaming.
TravisCarden Jul 9, 2024
0ccaa75
Add PHP Compatibility sniffs to AcquiaDrupalMinimal.
TravisCarden Jul 9, 2024
2a73493
Revert "allow package annotation"
TravisCarden Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Travis Carden <[email protected]>
  • Loading branch information
@danepowell @TravisCarden
danepowell and TravisCarden committed Jul 3, 2024
commit 1c884ee1cb2f02dcd02b97db98062cc14c4aca93
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 19,15 @@ Acquia Coding Standards for PHP includes a selection of sniffs from the followin

## Rulesets

Rules are split into rulesets according to the project *framework* and *visibility*:
Rules are split into rulesets according to the project *framework* and *audience*:

* Projects (e.g., Drupal modules) targeting the Drupal community should adopt a *Drupal* ruleset. All others should adopt a general *PHP* ruleset.
* Projects targeting the Drupal community, e.g., Drupal modules, should adopt a *Drupal* ruleset. All others should adopt a (more generalized) *PHP* ruleset.
* Public projects (e.g., open-source Drupal modules) should adopt a *non-strict* ruleset to facilitate external collaboration. All others should adopt a more opinionated *internal* ruleset.

There are four permutations of these guidelines, leading to four rulesets to choose from:

* [AcquiaPHP](src/Standards/AcquiaPHP/ruleset.xml) is based on PSR-12 and is intended for use on all public non-Drupal projects.
* [AcquiaPHPStrict](src/Standards/AcquiaPHPStrict/ruleset.xml) is based on AcquiaPHP and adds additional more opinionated standards. It is intended for use on all internal non-Drupal projects.
* [AcquiaPHPStrict](src/Standards/AcquiaPHPStrict/ruleset.xml) is based on AcquiaPHP and adds additional, more opinionated standards. It is intended for use on all internal, non-Drupal projects.
* [AcquiaDrupal](src/Standards/AcquiaDrupal/ruleset.xml) is based on the Drupal coding standard and is intended for use on all public Drupal projects.
* [AcquiaDrupalStrict](src/Standards/AcquiaDrupalStrict/ruleset.xml) is based on AcquiaDrupal and adds the more opinionated DrupalPractice standard. It is intended for use on all internal Drupal projects.

Expand Down
Loading