Fix incomplete multipart problem #113

iptq · 2018-11-20T08:50:57Z

Seems like hyper is reading until it sees \r\n, and since that's not being sent, I get

ERROR 2018-11-20T08:47:28Z: actix_web::pipeline: Error occurred during request handling, status: 500 Internal Server Error Multipart stream is incomplete

This just adds the \r\n to the end so hyper has no problem seeing it.

abonander · 2018-11-21T00:29:56Z

This actually appears to affect Actix, not Hyper. And really, I would consider this to be a correctness issue with Actix as RFC 2046 doesn't require a trailing CRLF (parts in square brackets are optional):

multipart-body := [preamble CRLF]
                  dash-boundary transport-padding CRLF
                  body-part *encapsulation
                  close-delimiter transport-padding
                  [CRLF epilogue]

It looks like Actix uses .readline() to read the boundary which is why it's failing to read the terminating boundary without a CRLF: https://github.com/actix/actix-web/blob/master/src/multipart.rs#L170

This change here isn't going to break anything, but it's not going to prevent Actix from having issues with other clients, either.

abonander · 2018-11-29T11:13:29Z

src/client/mod.rs

@@ -257,7 257,7 @@ impl<'a, W: Write> MultipartWriter<'a, W> {
 }

 // always write the closing boundary, even for empty bodies
- write!(self.inner, "--{}--", self.boundary)?;
+ write!(self.inner, "--{}--\r\n", self.boundary)?;


I'm prepared to merge this since Actix isn't moving quickly on the issue I opened. Can you add a comment here saying the CRLF is not specified for but some servers expect it?

abonander · 2019-01-28T22:34:41Z

Published as 0.16.1.

tack on final \r\n

3228562

abonander mentioned this pull request Nov 21, 2018

Don't use .readline() for multipart boundaries actix/actix-web#598

Closed

abonander reviewed Nov 29, 2018

View reviewed changes

abonander merged commit 9ce18d0 into abonander:master Jan 28, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix incomplete multipart problem #113

Fix incomplete multipart problem #113

iptq commented Nov 20, 2018

abonander commented Nov 21, 2018

abonander Nov 29, 2018 •

edited

Loading

abonander commented Jan 28, 2019

Fix incomplete multipart problem #113

Fix incomplete multipart problem #113

Conversation

iptq commented Nov 20, 2018

abonander commented Nov 21, 2018

abonander Nov 29, 2018 • edited Loading

Choose a reason for hiding this comment

abonander commented Jan 28, 2019

abonander Nov 29, 2018 •

edited

Loading