Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#106] Address new url.Parse behavior during setup #107

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

awoodbeck
Copy link

These changes should address the new url.Parse behavior. The relative SSH URL portion is treated as a port. Since ports parsed by url.Parse must now be numeric, this breaks relative SSH URLs.

The approach I took was to inject a temporary port number, parse the URL, and remove the injected port. All tests pass. That being said, this code needs more eyes on it to make sure all edge cases are addressed by these changes.

@ricardoboss
Copy link

Does this fix #106?

@awoodbeck
Copy link
Author

Does this fix #106?

It resolves the issue for me and is the most minimal approach I could come up with to address the issue. There's no telling when the author may rule on this PR, so feel free to use the master branch in my fork until then. My master branch is diverged from this repo only insofar as the import paths are concerned and to include my changes in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants