Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Parent node and add Clear Parent, Get Parent, Get Children node. #107

Merged
merged 3 commits into from
Mar 7, 2020

Conversation

tomoaki-e33
Copy link

  1. "Parent" node now considers parent inverse by default. Select "Object(Without Inverse)" type if you want to return to v3.1.4 behavior.
  2. Added "Clear Parent", "Get Parent", and "Get Children" node.

@tomoaki-e33
Copy link
Author

Screenshot:
スクリーンショット 2020-02-06 10 11 24

Copy link
Owner

@aachman98 aachman98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!
Approved the merge, but I've mentioned some very minor changes. See if you can find the time and modify the code a bit. Will merge this by tomorrow as well.

nodes/object_operators/ScClearParent.py Outdated Show resolved Hide resolved
nodes/object_operators/ScGetChildren.py Outdated Show resolved Hide resolved
nodes/object_operators/ScGetParent.py Outdated Show resolved Hide resolved
nodes/object_operators/ScParent.py Outdated Show resolved Hide resolved
nodes/object_operators/ScParent.py Outdated Show resolved Hide resolved
nodes/object_operators/ScParent.py Outdated Show resolved Hide resolved
nodes/object_operators/ScParent.py Outdated Show resolved Hide resolved
nodes/object_operators/ScParent.py Outdated Show resolved Hide resolved
@aachman98 aachman98 added the scheduled Feature to be released soon label Mar 6, 2020
@tomoaki-e33
Copy link
Author

Thanks for your review!

@aachman98 aachman98 merged commit c1ae5f7 into aachman98:master Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scheduled Feature to be released soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants