Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[issue #9] moving restriction validation to VariableNode fixes issue #11

Merged
merged 2 commits into from
Dec 8, 2017
Merged

[issue #9] moving restriction validation to VariableNode fixes issue #11

merged 2 commits into from
Dec 8, 2017

Conversation

xelalexv
Copy link
Collaborator

@xelalexv xelalexv commented Dec 7, 2017

Realized that restriction validation belongs to VariableNode, not SubstitutionNode. Moving it there fixes the issue.

a8m
a8m approved these changes Dec 7, 2017
View reviewed changes
Copy link
Owner

@a8m a8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @xelalexv!
LGTM. just a minor comment.

parse/node.go Outdated
return nil
}

//
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this //?

@xelalexv xelalexv merged commit 4e0f64a into a8m:master Dec 8, 2017
@xelalexv xelalexv deleted the issue_#9 branch December 8, 2017 08:05
@a8m a8m mentioned this pull request Dec 8, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a8m a8m a8m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xelalexv @a8m