Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.5.0 patch3 #189

Merged
merged 18 commits into from
Jul 11, 2022
Merged

1.5.0 patch3 #189

merged 18 commits into from
Jul 11, 2022

Conversation

a-r-j
Copy link
Owner

@a-r-j a-r-j commented Jul 8, 2022

Reference Issues/PRs

  • Refactors PDB Download util to support parallelisation.

What does this implement/fix? Explain your changes

What testing did you do to verify the changes in this PR?

Pull Request Checklist

  • Added a note about the modification or contribution to the ./CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./graphein/tests/* directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under ./notebooks/ (if applicable)
  • Ran python -m py.test tests/ and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., python -m py.test tests/protein/test_graphs.py)
  • Checked for style issues by running black . and isort .

a-r-j and others added 14 commits July 8, 2022 16:56
* update bioservices to account for new UniProt API (#187)

* update bioservices to account for new UniProt API

* update changelog

* Update PULL_REQUEST_TEMPLATE.md

* Graph plots (#186)

* Fix param name typo in function docstring

* add scaling node size by "rsa" feature as well as degree

* add option for scaling node size by meiler embedding dimensions.  Takes negative values to be zero.

* remove walrus operator := for compatability

* Add type hints

* Update changelog

Co-authored-by: Arian Jamasb <[email protected]>

Co-authored-by: Cam <73625486 [email protected]>
Copy link
Owner Author

@a-r-j a-r-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
18.9% 18.9% Duplication

@a-r-j a-r-j merged commit 553fd26 into master Jul 11, 2022
a-r-j added a commit that referenced this pull request Jul 14, 2022
* update bioservices to account for new UniProt API (#187)

* update bioservices to account for new UniProt API

* update changelog

* Update PULL_REQUEST_TEMPLATE.md

* Graph plots (#186)

* Fix param name typo in function docstring

* add scaling node size by "rsa" feature as well as degree

* add option for scaling node size by meiler embedding dimensions.  Takes negative values to be zero.

* remove walrus operator := for compatability

* Add type hints

* Update changelog

Co-authored-by: Arian Jamasb <[email protected]>

* 1.5.0 patch3 (#189)

* refactor PDB download to support parallelisation

* add tests for PDB download

* refactor PDB download function call in getcontacts

* add salt bridges and vdw interactions

* use multiprocess downloading in torch datasets

* add additional edge funcs

* add residue_id to dfs and additional constants

* update tests to account for residue id column

* update dl func to check for obsolete PDBs

* fix type error on paths

* fix obsolete test

* add bad pdb attr

* add return to PDB download util

* Merge master -> Patch (#190)

* update bioservices to account for new UniProt API (#187)

* update bioservices to account for new UniProt API

* update changelog

* Update PULL_REQUEST_TEMPLATE.md

* Graph plots (#186)

* Fix param name typo in function docstring

* add scaling node size by "rsa" feature as well as degree

* add option for scaling node size by meiler embedding dimensions.  Takes negative values to be zero.

* remove walrus operator := for compatability

* Add type hints

* Update changelog

Co-authored-by: Arian Jamasb <[email protected]>

Co-authored-by: Cam <73625486 [email protected]>

* patch torch geometric dataset and update changelog

* black, isort

* isort

Co-authored-by: Cam <73625486 [email protected]>

* 1.5.0 patch3 (#191)

* refactor PDB download to support parallelisation

* add tests for PDB download

* refactor PDB download function call in getcontacts

* add salt bridges and vdw interactions

* use multiprocess downloading in torch datasets

* add additional edge funcs

* add residue_id to dfs and additional constants

* update tests to account for residue id column

* update dl func to check for obsolete PDBs

* fix type error on paths

* fix obsolete test

* add bad pdb attr

* add return to PDB download util

* Merge master -> Patch (#190)

* update bioservices to account for new UniProt API (#187)

* update bioservices to account for new UniProt API

* update changelog

* Update PULL_REQUEST_TEMPLATE.md

* Graph plots (#186)

* Fix param name typo in function docstring

* add scaling node size by "rsa" feature as well as degree

* add option for scaling node size by meiler embedding dimensions.  Takes negative values to be zero.

* remove walrus operator := for compatability

* Add type hints

* Update changelog

Co-authored-by: Arian Jamasb <[email protected]>

Co-authored-by: Cam <73625486 [email protected]>

* patch torch geometric dataset and update changelog

* black, isort

* isort

* add edge tests

* remove unused workflow action

* bump for 1.5.0

* add vdw clashes to constants

Co-authored-by: Cam <73625486 [email protected]>

Co-authored-by: Cam <73625486 [email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant