Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds margins to InfoPannel for older OS #544

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LiYanan2004
Copy link
Contributor

Previous PR that has been closed without merging: #539

Based on #540, older OS still using padding around ScrollView which results in a hard clip. Technically, it's possible to add margins inside ScrollView, so, of course, older OS deserves that margin🤣.

The code here uses safe area to add margins which might be the same with the new margin API, but supports older OS.

@MattKiazyk
Copy link
Contributor

@LiYanan2004 can you show me what this looks like on MacOS < 14? Thanks

@LiYanan2004
Copy link
Contributor Author

Unfortunately, I have no device running macOS 13. But that piece of code should look the same as the latest OS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants