Release notes button isn't obvious #524
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤔 agree the 🔗 icon may not be (at first glance) easy to understand. I was trying to keep it clean, so I think having that full release button goes against that. Perhaps changing the icon - to a 🗒️ or something would help? |
|
I agree that the full text isn't as clean, so I understand why you went with the 🔗. I'm not sure if any other icon would be any more obvious, but the 🗒️ might be. I also considered making the 'Release Notes' text smaller and removing the button border so it would have a cleaner look, but I'm not sure if that would be any better since it would then just look like text. Do you think underlined text would look clean enough? I'm not sure if I like the idea of using web style in a native app though. 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to see the release notes for Xcode 15.3 but I didn't see a button in the info pane, so this being an open source project I forked the repo to add a button.
Then when I looked at the code I realized the 🔗 button is the release notes button I was planning on adding.
Now I know what the button does, but I obviously didn't understand it at first glance, and I didn't hover long enough to see the help tip either. So instead of adding a Release Notes button this PR replaces the 🔗 with text, to make it more discoverable
I don't know if this is the best solution, but I thought I'd share the idea and see what you think.
This approach also adds one more string to localize. I was able to copy out the pertinent bit of the ReleaseNotes.help string for a few of the romantic and germanic languages, but there are a few others left to do. I could look into doing those too if we decide to move forward with the text idea. (Or just use the help text directly, including the "see" part and not add a new string at all.)
PR
Released
