Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix logging in SubscriptionSource #1617

Merged

Conversation

kuznetsss
Copy link
Collaborator

For #1616. Later should be ported to develop as well.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 67.80%. Comparing base (665fab1) to head (d77b69a).
Report is 1 commits behind head on release/2.2.3.

Files with missing lines Patch % Lines
src/etl/impl/SubscriptionSource.cpp 15.38% 1 Missing and 10 partials ⚠️
src/etl/LoadBalancer.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           release/2.2.3    #1617       /-   ##
=================================================
- Coverage          67.87%   67.80%   -0.08%     
=================================================
  Files                234      234              
  Lines               9431     9438        7     
  Branches            5257     5264        7     
=================================================
- Hits                6401     6399       -2     
- Misses              1650     1653        3     
- Partials            1380     1386        6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kuznetsss kuznetsss merged commit 5004dc4 into XRPLF:release/2.2.3 Aug 29, 2024
16 checks passed
@kuznetsss kuznetsss deleted the 1616_Fix_logging_of_SubscriptionSource branch August 29, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants