Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuring hostname in Docker container #84

Open
pavelhoral opened this issue Aug 15, 2023 · 1 comment
Open

Allow configuring hostname in Docker container #84

pavelhoral opened this issue Aug 15, 2023 · 1 comment

Comments

@pavelhoral
Copy link
Member

Summary

Current docker image bootstraps DS with hostname set to localhost - https://github.com/WrenSecurity/wrends/blob/b9af6473dd85fb55f62aa4adb4cab5389ff2fa4a/.docker/bootstrap/setup.sh#L36C4-L36C16. That is a sensible default for sandbox deployments. But we need to be able to setup real hostname in production deployments.

Expected Result (Behavior You Expected to See)

Be able to provide additional environment property to set server hostname.
@pavelhoral
Copy link
Member Author

This might need additional research to provide arguments for why anyone should care about this setting... To be honest, I am not sure this configuration is that important in the end - I don't know if it plays any role in resolving server's own identity (e.g. for replication). It would be fine if this gets closed as invalid issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pavelhoral