-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GearSwap] Add Engage by ID Feature #2203
Open
Roland-J
wants to merge
1,328
commits into
Windower:dev
Choose a base branch
from
Roland-J:Engage-by-ID-(GearSwap)
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Slips libs for September FFXI update
Update slips.lua
Two new songs added in the September 2021 update. Names are not known yet.
Update setbgm.lua
…strosity-fix Gearswap shortcuts monstrosity fix
Locals, spacing dev table, format arg, no more length the rest of the owl
Dev -> Live
A few functions for decoding dialog entries
change based on CHA CHA CHA's info
fixed comment numbering for 0x01C
Dev -> Live
Add blacklist function.
Master Levels Update 1
variable fix
Adding Chemistry Set and Goujian to Slips library
Slips lib Update
[thtracker] variable fix
Dev -> Live
Changed to use boolbits and added Master Levels menu display data
Change to use Refs
Re-add Master flags comment
[gametime] fix //gt route
Trusts: Fix for player party member out-of-zone
Add items for June 2022 Update
Added DIKs for f13-f15.
DIKs for f11 & f12
Yush.lua updated DIKs
Yush: Added a VerboseKeys setting to enable key display in each macro set.
There is no spell called "Lightning Threnody"
0x0E8 is an outgoing packet.
[fields lib] fix wrong 0x0E8 packet direction
Adds a function that can engage by ID, with safeguards
Adds to the command handler logic for engaging mobs by id
Roland-J
changed the title
Engage by id (gear swap)
Add Engage by ID Feature to GearSwap
Jun 29, 2022
RubenatorX
changed the title
Add Engage by ID Feature to GearSwap
[GearSwap] Add Engage by ID Feature
Jun 29, 2022
Adds a clarity comment to the (potentially uncommon) usage of the ffxi var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Engage by ID
This pull request adds an engage by ID feature to the GearSwap core, allowing players to engage alts with send without needing to rely on, and occasionally be impacted by, the potential unreliability of
<bt>
and/assist
. It's also just plain faster.This would make GearSwap not only allow players to cast spells by mob ID, but also engage by mob ID.
Safeguards:
This feature includes the following safeguards:
/attack
,/attack on
,/attack off
,/attackoff
)/attack 12345678
" text input, by utilizing the ffxi variableCommands:
NOTE: Utilize a method, such as send's
<tid>
or<laststid>
to obtain valid mob ids for these commands./attack 12345678
- toggles engagement on the given mob (only disengages if the given mob is already engaged)/attack on 12345678
- engages or switches target to the given mob/attack off 12345678
- disengages from the given mob only if it is already engaged by the current player/attackoff 12345678
- disengages from the given mob only if it is already engaged by the current player- omitted, SE did not include this as a base command/attackon 12345678
How to Use:
alias attackonall send @all input /attack on
", then use "//attackonall <tid>
" ingame./target <stnpc>[newline]/con send @all input /attack on <laststid>
"Use Cases:
//send @all /attack on <tid>
" to engage all alts on the given mob//send @all input /attackoff <tid>
" while targeting said mob to disengage all alts from the given mob without disturbing alts that are engaged to a different mob//send charname /attack on <tid>
" to have that specific alt engage or switch-target to the given mobBehavior
You can expect much of the same behavior as when your client naturally generates these packets, but without your alts needing to do the preliminary targeting any longer.
Engage: Your client, all at once, automatically targets said mob (new), locks on, and engages.
Switch Target: Your client automatically switches to said mob (new), keeping your current targeting status (locked/unlocked).
Disengage: Your client disengages from said mob. (Does nothing if alt was engaged to a different mob.)
Noteworthy: While this feature doesn't check if the mob is claimed by another party/alliance, neither does the vanilla "Attack" command button. Add a logger to outgoing chunks and then try to attack a claimed enemy via the vanilla command button; you will notice that vanilla FFXI sends out an engage packet that the server rejects! It is for that reason that we didn't (potentially needlessly) complicate this aspect of the feature in comparison to vanilla FFXI's behavior in this same aspect.