Fixed replica_spec.rb and replica.rb #5649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All the tests which are failing in CI build are passing locally.
|
ragesoss
reviewed
Feb 13, 2024
lib/replica.rb
Outdated
| @@ -144,7 144,8 @@ def api_post(endpoint, key, data) | |||
| return if response.body.empty? | |||
| parsed = Oj.load(response.body) | |||
| raise unless parsed['success'] | |||
| parsed['data'] | |||
| filtered_data = parsed['data'].select { |article| data.include?(article['page_title']) } | |||
| return filtered_data | |||
There was a problem hiding this comment.
Why is this change to replica.rb included?
There was a problem hiding this comment.
Sorry, this change was not required.
Initially, due to the fact that i was seeing previous vcr response again and again, i thought that the api is not filtering out data with the provided tittle.
Now when i changed the vcr cassette name for recording response, got to know api is working fine as expected.
|
Found that now article "Autism" does not exist in namespace 118 --> Only reason leading to the failure of previous test case. |
|
Failing tests are flaky. |
|
Looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes #5647
This pr resolve the issue in the test case 'returns a list of existing articles' spec in spec/lib/replica_spec.rb. The original test was performing multiple tasks and was unreliable. To rectify this, I modularized the test into smaller tests, each focusing on individual articles.
Screenshots
Before:
After: