Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored article_finder_row from class component to functional component #5563

Conversation

omChauhanDev
Copy link
Contributor

@omChauhanDev omChauhanDev commented Dec 26, 2023

What this PR does

This PR converted the article_finder_row from class to functional component.
useState and useEffect hooks are used where they are required.

Videos

For Article Finder Row
Before:
Before.webm

After:
After.webm

Kindly review my work.

@omChauhanDev
Copy link
Contributor Author

@ragesoss Kindly send me slack invite.
My Email id - [email protected]

@omChauhanDev
Copy link
Contributor Author

Also converted Article Finder from class component to functional component.

Videos

For Article Finder
Before:
Before.webm

After:
After.webm

@ragesoss Kindly review both of these commits and provide feedback accordingly.

Email for Slack Workspace - "[email protected]"

@ragesoss
Copy link
Member

ragesoss commented Jan 2, 2024

Thanks! I'd prefer separate PRs for each component, as I like to have as little to review in each PR as possible. Too many lines of JS quickly becoming overwhelming for me.

@omChauhanDev
Copy link
Contributor Author

Sorry, for any inconvenience i rolled back second component(article_finder) to its previous state. Kindly have a look and i will remember from next time to create a separate pull request for every refactored component.
Thanks

@omChauhanDev
Copy link
Contributor Author

@ragesoss kindly send me slack invite.
Email - [email protected]

@ragesoss
Copy link
Member

ragesoss commented Jan 5, 2024

@ragesoss kindly send me slack invite. Email - [email protected]

Looks like you've already joined; Slack says that's an existing member.

@ragesoss ragesoss merged commit 86ac0a2 into WikiEducationFoundation:master Jan 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants