AMD encoding support #353
Open
AMD encoding support #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding correct changing of codec settings, not through custom settings, and provide readable parameters.
|
For now the tasks are:
|
|
@vipotaenko02 What's the status of this? BTW The newest release of https://github.com/Wieku/FFmpeg-Builds should now support amf, can you test it? |
Wieku
requested changes
Feb 26, 2024
| "path/filepath" | ||
| "strings" | ||
|
|
||
| "github.com/wieku/danser-go/framework/env" |
There was a problem hiding this comment.
Please use gofmt instead of goimports for formatting. It looks better in general but for now I prefer to keep consistency.
|
I have a mini-PC with 8845HS running Ubuntu Server, i can test amf and vaapi on that. Also what about av1 support? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this will work perfectly but I will continue to contribute to this request. I know support for AMD hardware encoding was dropped, but at least knowing the risk in edge cases like low-end CPU this may help. And there is also an opened issue about AMD pro drivers on Linux, which may help encoding work better there (not sure though, for now I can only test Windows support, but eventually I'll get working on a Linux support too). For the time being, while support is experimental I will build a forked version with changes I made there. If anyone's interested, testing will be greatly helpful.