Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSS so the specification shows on narrow viewports without horizontal scrolling. #1774

Closed
matj1 opened this issue Aug 6, 2024 · 7 comments

Comments

@matj1
Copy link
Contributor

matj1 commented Aug 6, 2024

The width of the pages of the specification (like this) is hardcoded to 1000px. That means that, if I view the webpage with split screen, it shows a horizontal scrollbar and I can"t see whole lines without scrolling.

Specifically, I have the browser window at a half of a Full HD monitor, so the width of the webpage is [960 − [the scrollbar"s width]] pixels, which is 945 pixels according to the inspector. So 55 pixels are hidden. I need to scroll to see them even if the content is mostly alright when it is narrower.

Solution

  • Remove width: 1000px from div.document and div.footer in custom.css.
  • Also remove width: 940px from div.document and div.footer in alabaster.css.

The second thing is to allow the page to be even narrower, which works until 860 pixels, when the layout breaks both with and without this fix.

The following shows which CSS rules are supposed to be removed; these are the crossed out ones with empty checkboxes.

Snímek obrazovky z 2024-08-06 16-25-46
Snímek obrazovky z 2024-08-06 16-24-48

@matj1 matj1 changed the title Fix CSS so it shows on narrow viewports without horizontal scrolling. Fix CSS so the specification shows on narrow viewports without horizontal scrolling. Aug 6, 2024
@rossberg
Copy link
Member

rossberg commented Aug 8, 2024

Good idea. Would you be willing to contribute a PR?

@matj1
Copy link
Contributor Author

matj1 commented Aug 8, 2024

Probably. But alabaster.css is from a theme built in sphinx, so I can"t change it. So I change the the mentioned cases in custom.css width: 1000px to width: unset, which should do the same.

@matj1
Copy link
Contributor Author

matj1 commented Aug 8, 2024

To which branch should I commit it? main is protected, and I don"t know what other branches are for.

@rossberg
Copy link
Member

rossberg commented Aug 8, 2024

You"ll probably have to fork and create a pull request.

Does the footnote size need changing, too?

@matj1
Copy link
Contributor Author

matj1 commented Aug 8, 2024

The footnote size too needs changing because that too is fixed to 1000 pixels.

@matj1
Copy link
Contributor Author

matj1 commented Aug 9, 2024

It seems that I shouldn"t make a pull request according to the contributing guidlines because I am not in W3C Community Group, and I don"t bother to join it just because of this. At worst, the pull request will be rejected, but then I encourage everyone there to make this change in my stead.

@rossberg
Copy link
Member

rossberg commented Aug 9, 2024

Oh, okay, I already merged it. I believe we have accepted PRs in the past that were minor enough not to raise legal questions, like fixing typos.

@rossberg rossberg closed this as completed Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants