Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numeric type usage is weird #8

Closed
domenic opened this issue May 26, 2015 · 3 comments
Closed

Numeric type usage is weird #8

domenic opened this issue May 26, 2015 · 3 comments
Assignees
@reillyeon

Comments

@domenic
Copy link

domenic commented May 26, 2015

float for usbVersion; octet for deviceClass etc.; ...

If there's no intention for people to do arithmetic on these, I'd definitely suggest strings.

Floats are especially problematic since e.g. usbVersion: 3.1 actually means usbVersion: 3.10000000000000008882.
@reillyeon reillyeon self-assigned this May 26, 2015
@reillyeon reillyeon mentioned this issue May 26, 2015
Closed
@reillyeon
Copy link
Collaborator

Commit 0c16cf6 resolved this by creating a USBVersionNumber struct to represent versions.

@domenic
Copy link
Author

domenic commented Jun 4, 2015

But... Why?? Majorly overcomplicated.

@domenic
Copy link
Author

domenic commented Jun 4, 2015

Whatever, we can leave it for the TAG review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reillyeon reillyeon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@reillyeon @domenic