Add github actions and test #45
Conversation
| push: | ||
| branches: | ||
| - 'master' | ||
| - 'add-gh-actions' |
There was a problem hiding this comment.
just for initial testing, next commit will remove it again, now that it's a PR
| PORT=3005 | ||
|
|
||
| # save the query to eval later | ||
| status_request="curl -X POST -H 'Content-Type: application/json' -d @tests/test_req.json http://localhost:${PORT}" |
There was a problem hiding this comment.
just requests the healthcheck example, included in this repo
|
@jcoupey doesn't quite work yet for some reason.. don't think it's the github action, I guess there's still a problem with the secrets: ref docker/login: https://github.com/docker/login-action#docker-hub |
|
what's your username? you need to use the docker ID (for me nilsnolde), not the email (I think you log in on dockerhub.com with email, but you can't authenticate with it, dockerhub is a mess) |
|
you can try in your terminal if it works with the values: |
|
I was using docker id all right (not email). I just reset the The fun (!?) thing is that using the same credentials in the above |
|
And the RC tag is now available on Docker hub: https://hub.docker.com/layers/vroomvrp/vroom-docker/1.11.0-rc.1/images/sha256-f9fb835cc471676d39aaa0b89c16c8c2e2caa8c545e445ed4e05806e1c9e6d0c?context=explore Nit: this tag breaks the convention from previous versions, it should be v1.11.0-rc.1 |
|
In related news: looks like GitHub only relies on diffs to decide if a PR is merged, regardless of whether the branch has actually been git-merged. A bit misleading at first! |
|
great!
that's then a bug in https://github.com/docker/metadata-action#typesemver, where it says you wanna remove the docker image from dockerhub and I'll force push the tag again with the fix above so it's consistent? |
Yes, I just deleted it. |
|
jeez.. https://github.com/VROOM-Project/vroom-docker/runs/3813717695?check_suite_focus=true the metadata action still thinks the btw, nothing was pushed this time, I cancelled the workflow before it got that far |
|
Thanks for the effort @nilsnolde. |
|
wasn't quite out of the woods yet.. didn't really work for anything else than tagged releases. to avoid overly complex instructions, I just split it up in 2 action files. |
and sorry @jcoupey , those env vars were just half the story.. you'd also need to generate a token on dockerhub that you can use as the docker password env: https://github.com/docker/login-action#docker-hub. would've expected that your actual password works, but it's safer this way anyways I guess..
can you let me know when you did that? once that's done I'll push a v1.11.0-rc.1 tag and see if it pushes to dockerhub alright and we can merge (apart from general review)..
the test already went through: https://github.com/VROOM-Project/vroom-docker/runs/3805886373?check_suite_focus=true