Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix breaks location_index #937

Merged
merged 6 commits into from
Jun 26, 2023
Merged

Fix breaks location_index #937

merged 6 commits into from
Jun 26, 2023

Conversation

jcoupey
Copy link
Collaborator

@jcoupey jcoupey commented Jun 22, 2023 •
edited
Loading

Issue

fixes #877

Tasks

  • Make Step::location optional
  • Only serialize location[_index] based on existing value
  • While we're at it refactor various job_type members to be optional instead of holding dummy JOB_TYPE::SINGLE values
  • Update CHANGELOG.md
  • review

@jcoupey jcoupey added this to the v1.14.0 milestone Jun 22, 2023
@jcoupey jcoupey merged commit d9166d2 into master Jun 26, 2023
@jcoupey jcoupey deleted the fix/breaks-location-index branch June 26, 2023 10:23
@jcoupey jcoupey mentioned this pull request Jun 26, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
API bug refactor
Projects
None yet
Milestone
v1.14.0
Development

Successfully merging this pull request may close these issues.

Breaks steps have meaningless location_index values in output
1 participant
@jcoupey