-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor cost wrapper #829
Conversation
Scaling input durations internally means we have to also scale values in time windows. The problem is that when using regular timestamps like 1669022846, scaling by a factor of 100 will quickly bring us over the limit for a To avoid the memory overhead my plan is to refactor types further so that:
That last point is the one requiring the most changes, but as soon as everything happens in the signed world with enough room, we should be safe from the kind or problem spotted in #831, while not increasing our memory footprint. |
I finally went with introducing new "user-facing" cost types Just as sketched in #828, a scaling phase applies upon problem definition, then back when formatting solutions. |
Well, almost: as the last CI build failure shows, users of the C API that provide custom matrices will have to switch from |
This adds a lot more boilerplate than I first though it would, especially in order to make sure reported results are consistent in output after scaling back to
On that last point, here are some values for average instance computing time per benchmark class, using
|
Issue
This PR is an attempt to fix #828.
Tasks
CostWrapper::cost
andduration
vroom::Solution
-related objectsCHANGELOG.md