-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend CI strategy to include g and clang installed on Ubuntu 22.04 #817
Conversation
Thanks for picking this up! I'd be in favor of simply updating the Ubuntu version to 22.04 (and explicitly pointing to the newest compiler versions) since:
What do you think? |
All of this makes sense to me. I left the old checks as I was not sure whether there was some commitment to support the particular OS/compiler version combination. Since there is none, we can simply use the latest versions. I can imagine this will closely match what people use as their development environment anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new builds passed seamlessly so we're fine. Can you just apply the same change to the vroom_libosrm.yml
workflow? It should trigger a new libosrm
build and cache both g -9
and clang -10
versions for further CI builds.
Hum, I should have anticipated this would fail since OSRM v5.26.0 has some outdated dependencies and does not compile any more on Ubuntu 22.04. Making the switch to v5.27.1 should solve this problem, and it's also a good move anyway. |
Yeah, I was wondering what the problem was. |
@kkarbowiak when you have time, can you push a commit changing the |
Issue #816
I added Ubuntu 22.04 to the CI build matrix using both g and clang , but without specifying their versions. According to this table Ubuntu 22.04 image on GitHub includes clang 12, 13, and 14 and g 9, 10, and 11. Without specifying version the latest one is used (that is, clang 14 and g 11).
Tasks
CHANGELOG.md
(remove if irrelevant)