Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend CI strategy to include g and clang installed on Ubuntu 22.04 #817

Merged
merged 5 commits into from
Nov 5, 2022

Conversation

kkarbowiak
Copy link
Contributor

@kkarbowiak kkarbowiak commented Nov 3, 2022

Issue #816

I added Ubuntu 22.04 to the CI build matrix using both g and clang , but without specifying their versions. According to this table Ubuntu 22.04 image on GitHub includes clang 12, 13, and 14 and g 9, 10, and 11. Without specifying version the latest one is used (that is, clang 14 and g 11).

Tasks

  • Update CHANGELOG.md (remove if irrelevant)
  • review

@kkarbowiak kkarbowiak marked this pull request as ready for review November 3, 2022 21:47
@jcoupey jcoupey added the CI label Nov 4, 2022
@jcoupey jcoupey added this to the v1.13.0 milestone Nov 4, 2022
@jcoupey
Copy link
Collaborator

jcoupey commented Nov 4, 2022

Thanks for picking this up! I'd be in favor of simply updating the Ubuntu version to 22.04 (and explicitly pointing to the newest compiler versions) since:

  • we don't commit to any extensive build checks platform-wise;
  • we'll have to drop support/checks for the oldest compilers at some point anyway, so it may be now;
  • doubling the number of CI builds sounds like a waste of time and resources for a small benefit;
  • it would keep the workflow simpler.

What do you think?

@kkarbowiak
Copy link
Contributor Author

All of this makes sense to me. I left the old checks as I was not sure whether there was some commitment to support the particular OS/compiler version combination. Since there is none, we can simply use the latest versions. I can imagine this will closely match what people use as their development environment anyway.

Copy link
Collaborator

@jcoupey jcoupey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new builds passed seamlessly so we're fine. Can you just apply the same change to the vroom_libosrm.yml workflow? It should trigger a new libosrm build and cache both g -9 and clang -10 versions for further CI builds.

@jcoupey
Copy link
Collaborator

jcoupey commented Nov 4, 2022

Hum, I should have anticipated this would fail since OSRM v5.26.0 has some outdated dependencies and does not compile any more on Ubuntu 22.04. Making the switch to v5.27.1 should solve this problem, and it's also a good move anyway.

@kkarbowiak
Copy link
Contributor Author

Yeah, I was wondering what the problem was.

@jcoupey
Copy link
Collaborator

jcoupey commented Nov 4, 2022

@kkarbowiak when you have time, can you push a commit changing the env.osrm-tag to v5.27.1 in the vroom_libosrm workflow to see if it works?

@jcoupey jcoupey merged commit da09650 into VROOM-Project:master Nov 5, 2022
@kkarbowiak kkarbowiak deleted the ci/ubuntu-22.04 branch November 7, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants