-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
error: no type named 'OptionException' in namespace 'cxxopts' issue #997
Comments
I have no idea what "build the bottle for Sonoma" actually means, but I guess that's beside the point. What version of VROOM are you trying to build here? This looks like a problem with |
It is related to building Vroom on MacOS for brew. Anyway, the issue is that brew is not using the cxxopts or rapidjson from the Vroom repository, instead they are injecting their own versions, causing the source mismatch. I have the same issue building it on MacOS 13, AARM M1.
Bumping cxxopts should do the trick. |
I kinda figured out but I have to say the name is somewhat misleading. ;-)
Right, that was my intuition too. Depending on the cxxopts version, it means either:
Only in the latter case would we need to do something, but I would be surprised since we're currently on |
Can someone confirm the cxxopts version at brew is older than |
They are using the newest version, I have taken a look at the cxxopts releases and 3.1 made some changes on the exceptions. The change looks small enough, and I can make PR, hopefully not breaking anything in the process.
|
Does this means that the |
Yea, they nuked the previous version of exceptions and replaced them with new one. |
OK, the changelog over there states "The project adheres to semantic versioning" but nevermind. Thanks for the PR! |
@jcoupey Would an interim release v1.13.1 with the PR not be advisable? - Working on a aws Lambda container for vroom and it would be helpful. |
You should have zero issues with building lambda layers with current version. |
I don't really understand: when using |
There is issue with checkout in Dockerfile, submodules are using master branch which have new cxxopts. |
|
@jamesjjk You can use this one for now and it should do the trick. |
git clone --branch $VROOM_RELEASE --recurse-submodules https://github.com/VROOM-Project/vroom.git |
@Orthae You were too fast :) thank you! I also would like to commit some additional constraint features that I still have to document - and a aws lambda image that I will work on in other tickets/branches |
👋 while trying to build the bottle for sonoma, we found there is build issue with
error: no type named 'OptionException' in namespace 'cxxopts'
, details as below:brew config
full build log, https://github.com/Homebrew/homebrew-core/actions/runs/6255124360/job/16983922323
relates to Homebrew/homebrew-core#142161
The text was updated successfully, but these errors were encountered: