-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Underflow in insertion regrets #831
Comments
The same kind of problem exists in our |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While working on #828 I noticed a solving change related to signedness modification. Turns out that this is because we're mixing signed and unsigned values here:
vroom/src/algorithms/local_search/local_search.cpp
Lines 194 to 206 in 4b898ec
The result of
_input.get_cost_upper_bound()
is unsigned so it's possible to have an underflow wheneverroute_job_insertions[i][j].eval.cost
(signed value) is negative. Cost insertions should be positive in theory but in reality they may be negative whenever the triangular inequality is broken. This is quite rare but does happens in practice with real-life instances, and also with e.g. Solomon instances due to rounding precision.There is no risk of crash, or providing a screwed solution, but we're discarding some (good) insertions options there so this piece of code does not always behave as intended.
The text was updated successfully, but these errors were encountered: