Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated code in TSP::cost() and TSP::symmetrized_cost() functions #812

Closed
kkarbowiak opened this issue Nov 2, 2022 · 2 comments
Closed

Duplicated code in TSP::cost() and TSP::symmetrized_cost() functions #812

kkarbowiak opened this issue Nov 2, 2022 · 2 comments
Labels
refactor TSP
Milestone
v1.13.0

Comments

@kkarbowiak
Copy link
Contributor

Both functions are exactly the same, but operate on different cost matrices. The common code can be extracted to a function parametrised with matrix to use.
@kkarbowiak kkarbowiak mentioned this issue Nov 2, 2022
Merged
2 tasks
@jcoupey jcoupey added this to the v1.13.0 milestone Nov 3, 2022
@jcoupey
Copy link
Collaborator

jcoupey commented Nov 3, 2022

Good catch, always nice to deduplicate some code!

@jcoupey
Copy link
Collaborator

jcoupey commented Nov 3, 2022

Done in #813.

@jcoupey jcoupey closed this as completed Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor TSP
Projects
None yet
Milestone
v1.13.0
Development

No branches or pull requests
2 participants
@jcoupey @kkarbowiak