Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add number of routes to output #524

Closed
jcoupey opened this issue Jun 3, 2021 · 2 comments · Fixed by #575
Closed

Add number of routes to output #524

jcoupey opened this issue Jun 3, 2021 · 2 comments · Fixed by #575
Labels
API enhancement good first issue
Milestone
v1.11.0

Comments

@jcoupey
Copy link
Collaborator

jcoupey commented Jun 3, 2021

When debugging/working on instances, it's often useful to compare number of routes in solutions. Of course this info is only a jq '.routes | length' call away, but it would be nice to have it directly available as summary.routes. This would also be similar to how we report the unassigned tasks and their number in summary.
@jcoupey jcoupey added this to the v1.11.0 milestone Jun 3, 2021
@Yash-Goyal007
Copy link

I want to work on this issue!!!!

@jcoupey
Copy link
Collaborator Author

jcoupey commented Jun 4, 2021

@Yash-Goyal007 thanks for offering to help! This is mostly a matter of storing the value in the Summary object on the C side and adding it in the json output. You can re-use the same existing logic as with the current unassigned value.

  • adding a member for number of routes in Summary would happen here;
  • passing the value for Summary would happen in the Solution ctor;
  • serializing the Summary object happens here.

@jcoupey jcoupey mentioned this issue Sep 14, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API enhancement good first issue
Projects
None yet
Milestone
v1.11.0
Development

Successfully merging a pull request may close this issue.

Output number of routes VROOM-Project/vroom
2 participants
@jcoupey @Yash-Goyal007