-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profile type not checked in input #355
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current way we parse strings in json input is as follows:
vroom/src/utils/input_parser.cpp
Lines 50 to 53 in 638f6d1
This is currently only used to retrieve the
vehicle.profile
value (if present). We enforce a check on whether the key exists but not on the actual type before callingGetString
. As a result, setting e.g."profile": 42
for a vehicle hits arapidjson
assertion or crashes.The text was updated successfully, but these errors were encountered: