Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prettier (from #59) #76

Draft
wants to merge 15 commits into
base: v2-mst-aptd-gcms-lcz-sty
Choose a base branch
from
Draft

Conversation

Vadorequest
Copy link
Member

@Vadorequest Vadorequest commented May 31, 2020

@Vadorequest
Copy link
Member Author

[GitHub Actions]
Deployment SUCCESS
Commit 64fc674 successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-nyuq3nt9g.now.sh
Deployment aliased as https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-prettier.now.sh

@Vadorequest
Copy link
Member Author

[GitHub Actions]
E2E tests SUCCESS

@Vadorequest
Copy link
Member Author

[GitHub Actions]
Deployment SUCCESS
Commit 8e4c39c successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-cujrhrrbc.now.sh
Deployment aliased as https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-prettier.now.sh

@Vadorequest
Copy link
Member Author

@samuelcastro I've made some more attempts and wasted a few more hours on this.

Overall, Prettier makes code look worse than before, their non-configurable opinionated choices aren't for me.

Do you know of any alternative? Couldn't eslint do some of it, maybe?

@Vadorequest
Copy link
Member Author

[GitHub Actions]
Deployment SUCCESS
Commit f0a2e21 successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-g9ta5k38v.now.sh
Deployment aliased as https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-prettier.now.sh

@Vadorequest
Copy link
Member Author

https://www.reddit.com/r/javascript/comments/8as6ns/i_dont_like_prettier/

Nobody loves what prettier does to their syntax

Everyone loves what prettier does to their coworkers' syntax

🤣

@Vadorequest
Copy link
Member Author

https://github.com/prettier/prettier-eslint may likely be the best alternative, it's basically a customisable prettier through eslint rules.

@Vadorequest
Copy link
Member Author

[GitHub Actions]
Deployment SUCCESS
Commit a1a9676 successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-l5jev0oz8.now.sh
Deployment aliased as https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-prettier.now.sh

@Vadorequest
Copy link
Member Author

[GitHub Actions]
Deployment SUCCESS
Commit 6c758a0 successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-pxt4h1y79.now.sh
Deployment aliased as https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-prettier.now.sh

@Vadorequest
Copy link
Member Author

[GitHub Actions]
Deployment SUCCESS
Commit 408c622 successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-km78d3trv.now.sh
Deployment aliased as https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-prettier.now.sh

@Vadorequest
Copy link
Member Author

[GitHub Actions]
Deployment SUCCESS
Commit 7578611 successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-qgw82l00w.now.sh
Deployment aliased as https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-prettier.now.sh

@samuelcastro
Copy link
Contributor

@samuelcastro I've made some more attempts and wasted a few more hours on this.

Overall, Prettier makes code look worse than before, their non-configurable opinionated choices aren't for me.

Do you know of any alternative? Couldn't eslint do some of it, maybe?

I don't have any other alternative, we could stick with just eslint for now.

@Vadorequest
Copy link
Member Author

I've tried a lot with prettier, and I'm not satisfied with the job it does. While it surely helps on some part of the code, it also makes other parts less readable/maintainable.

We'll stick to eslint for now, I hope it evolves in the right direction, or a proper alternative is made available.

@Vadorequest Vadorequest force-pushed the v2-mst-aptd-gcms-lcz-sty branch 3 times, most recently from 1dcbd4d to 9da75b0 Compare June 5, 2020 14:24
@Vadorequest Vadorequest marked this pull request as draft June 5, 2020 14:33
@Vadorequest
Copy link
Member Author

[GitHub Actions]
Deployment SUCCESS
Commit c8af640 successfully deployed to https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-qgw82l00w.now.sh
Deployment aliased as https://nrn-v2-mst-aptd-gcms-lcz-sty-c1-prettier.now.sh

@Vadorequest
Copy link
Member Author

FYI I'm following https://github.com/romefrontend/rome new features and hope it'll eventually be able to replace Prettier/EsLint.

@Vadorequest Vadorequest mentioned this pull request May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants