Display Username Capitalization and Trailing Char Fix #2027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morebytes
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the in-app SSO username error where acceptable usernames with trailing characters or random capitalization are displayed as such. See photos below of examples:
Changelog
[General] [Fix] - reformats displayed username in app without trailing character and uniform capitalization.
Test Plan
Sign in and out on the profile page using random capitalization and by entering a space followed by any random strings of characters after your UCSD email address. The app should still log you in if you have trailing characters/weird capitalization (this is an attribute/bug of SSO and not something for us to fix) but should now display your username or email in lowercase without any random trailing characters (Note: app will prevent you from logging in if you do a string of random characters after your username rather than your email).