Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: TryGhost/Ghost
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.101.2
Choose a base ref
...
head repository: TryGhost/Ghost
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.101.3
Choose a head ref
  • 3 commits
  • 10 files changed
  • 2 contributors

Commits on Nov 21, 2024

  1. Refactored webhook restriction to WebhookTrigger 

    ref https://linear.app/ghost/issue/AP-598

This is not a change in functionality.

The ActivityPub integration is an `internal` integration, because we want it to
be available regardless of the plan a Ghost(Pro) site is on. However the
webhooks service is not able to differentiate between webhooks for a custom
integration and an internal one.

Rather than disable webhooks entirely when the custom integrations limit
active, we want to allow webhooks for internal integrations to work. The first
step towards that is keeping the listener for the model events and have the
limiting happen in the WebhookTrigger which allows us to be more specific as to
which webhooks should be triggered or not.
    @allouis
    allouis committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    263c493 View commit details
    Browse the repository at this point in the history

  2. Fixed webhooks not firing for internal integrations 

    ref https://linear.app/ghost/issue/AP-598

We want to make sure that webhooks for internal integrations are fired even
when the custom integrations limit has been hit. In order to test this we've
had to update the fixtureManager to allow passing the integration type when
inserting fixture webhooks into the db.
    @allouis
    allouis committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    3265e25 View commit details
    Browse the repository at this point in the history

  3. v5.101.3

    @github-actions
    github-actions[bot] committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    a238960 View commit details
    Browse the repository at this point in the history
Loading