refactor(standalone-kafka) #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osoykan
force-pushed
the
improve-serde-standalone-kafka
branch
2 times, most recently
from
491b317
to
3d915c4
Compare
osoykan
commented
Dec 3, 2024
| Input1.parseFrom(it.toByteArray()) == input1Message | ||
| } | ||
| } | ||
| shouldBeConsumed<Input1> { |
There was a problem hiding this comment.
@DariusKlein, I have implemented the changes I mentioned in #560, and improved the ser/de operations. That led us to use the simple and clean DSL again, just FYI. And here are the tests you have written changed a little bit.
Feel free to give any feedback!
Code Coverage
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #664 /- ##
========================================
Coverage 81.59% 81.60%
========================================
Files 85 69 -16
Lines 2532 1957 -575
Branches 163 111 -52
========================================
- Hits 2066 1597 -469
Misses 366 296 -70
Partials 100 64 -36 ☔ View full report in Codecov by Sentry. |
osoykan
force-pushed
the
improve-serde-standalone-kafka
branch
2 times, most recently
from
d1f78a9
to
71640f4
Compare
… bridge the messages and let users select their ser/de #560
osoykan
force-pushed
the
improve-serde-standalone-kafka
branch
from
71640f4
to
9074daf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use StoveSerde<Any,ByteArry> interface to bridge the messages and let users select their ser/de #560