by default comment out keys which are not needed #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hey don't accidentally copy the whole config_template.yaml and don't set these properly
luciferlinx101
approved these changes
Jul 6, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #668 /- ##
=======================================
Coverage 56.94% 56.94%
=======================================
Files 134 134
Lines 5428 5428
Branches 548 548
=======================================
Hits 3091 3091
Misses 2220 2220
Partials 117 117 ☔ View full report in Codecov by Sentry. |
Fluder-Paradyne
added a commit
that referenced
this pull request
Jul 7, 2023
…hey don't accidentally copy the whole config_template.yaml and don't set these properly (#668)
Fluder-Paradyne
added a commit
that referenced
this pull request
Jul 7, 2023
…hey don't accidentally copy the whole config_template.yaml and don't set these properly (#668)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hey don't accidentally copy the whole config_template.yaml and don't set these properly
Description
By default comment out keys which are not needed by default so that they don't accidentally copy the whole config_template.yaml and don't set these properly
Type of change
Checklist