Dark mode issue for invite user with email #7513 #7532
Conversation
|
|
There was a problem hiding this comment.
HEy @Yash-rai-29 ,
Thanks for the PR. It's working fine in darkmode but not able to see the icon in light mode. Could you please look into it? Attaching the screenshot
|
@kavinvenkatachalam Appreciate your feedback and the screenshot! |
|
👋 Hi @kavinvenkatachalam, Just a friendly reminder regarding the pull request on the fix/dark-mode-icon branch in the Yash-rai-29/ToolJet repository. @Yash-rai-29 requested your review 4 days ago. There's one change requested, and we'd greatly appreciate your insights and feedback. |
There was a problem hiding this comment.
@Yash-rai-29 - On clicking the Add Users nothing happens. The recent change breaking the functionality. Please take a look
There was a problem hiding this comment.
@Yash-rai-29 On clicking Add users button nothing happens. Please take a look
Pull Request Description
Fixes #7513
Issue Resolved
This pull request addresses the dark mode issue for the "Invite user with email" feature, as reported in issue #7513.
Proposed Changes
To enhance visibility in dark mode, the icon color for the "Email" feature has been updated to a lighter shade, specifically white, ensuring improved contrast and visibility.
Steps to Verify
Navigate to the workspace settings.
Select "Users" and click "Add Users."
Proceed to invite users via email and observe the icon color in dark mode.
Screenshots
Attached screenshots showcasing the updated icon color in dark mode.
Before resolving the issue: -
After resolving the issue: -
Version Information
Previous Version: 2.17.5-ee2.5.10-cloud2.0.9
Updated Version: [Insert version with the proposed changes]
Additional Notes
This change is aimed at improving the user experience in dark mode by addressing the visibility concerns for the "Invite user with email" feature.
Any feedback or further adjustments are welcomed for an optimal resolution of the reported issue.