Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : Page change doesn't happen for table with CSA in viewer #10457

Merged

Conversation

stepinfwd
Copy link
Contributor

fixes : Page change doesn't happen for table with CSA(use button) in viewer mode.

steps

  1. Add table
    2)Copy table
  2. attach query to table 1 and add a button and use Contol component action to page change
  3. preview and in viewer page doesn't switch
Screenshot 2024-07-25 at 3 32 06 PM

@TooljetBot
Copy link
Collaborator

TooljetBot commented Jul 25, 2024

Code Review Agent Run #3048e8

  • AI Based Review: ✔️ Successful

High-level Feedback

Ensure that the new parameter 'duplicateCurrentState' is thoroughly tested across all scenarios to prevent regressions. Consider adding unit tests to validate the new functionality and ensure robustness. Review the impact of this change on performance and maintainability, and document the new parameter usage clearly for future reference.

AI Code Review powered by Bito Logo

Copy link

sonarcloud bot commented Jul 25, 2024

@johnsoncherian johnsoncherian merged commit cb1c5c6 into fix/appbuilder-stability-and-ui Jul 30, 2024
31 checks passed
@johnsoncherian johnsoncherian deleted the bugfix/table-page-changing branch July 30, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants