Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add datasource button- loading state #10322

Open
nechalmaggon opened this issue Jul 10, 2024 · 3 comments
Open

Add datasource button- loading state #10322

nechalmaggon opened this issue Jul 10, 2024 · 3 comments
Assignees
@VishalMCF
Labels
bug Something isn't working community contribution good first issue Good for newcomers platform roadmap up-for-grabs

Comments

@nechalmaggon
Copy link
Collaborator

nechalmaggon commented Jul 10, 2024 •
edited
Loading

While adding the data source the loader on add button is common for all the data sources on the page. Thus, when you try to add one, and hover over any other card, it is also showing the loading on other datasource cards.

Screen.Recording.2024-07-10.at.1.18.41.PM.mov
@nechalmaggon nechalmaggon added bug Something isn't working roadmap platform labels Jul 10, 2024
@VishalMCF
Copy link

@nechalmaggon @PriteshKiri

Can you please assign this to me?

I have an approach. right now the the set loading state is getting set for all the datasource items. It is common for all of them. If instead of keeping only a boolean value in the useState() we put an object that contains key-value pairs where key is the data source key and the value is boolean,
Would that work?

@VishalMCF
Copy link

@nechalmaggon @PriteshKiri
I have fixed the issue using the above approach. Here is a recorded video=>

I was able to test the changes manually by adding a setTimeout otherwise It was not possible.

Untitled.mov

@VishalMCF VishalMCF mentioned this issue Jul 25, 2024
Open
@PriteshKiri
Copy link
Collaborator

Thanks for your contribution @VishalMCF. Moving the issue to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VishalMCF VishalMCF

Labels
bug Something isn't working community contribution good first issue Good for newcomers platform roadmap up-for-grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@VishalMCF @PriteshKiri @nechalmaggon