Async version of functions in os.path #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relevent test is also added
Calls of rename, mkdir, rmdir are added together with tests
Documented os function calls
Including makedirs and removedirs
|
This looks very helpful @Tinche any plans merging this one? |
|
I would love to see this merged, I found myself rewriting these functions over and over again. |
|
Thanks, I cleaned this up and merged it manually! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think os.path function would be commonly used. Their corresponding async version is now provided. Functions of
path.exist,path.isfile,path.isdir,path.getsize,path.getmtime,path.getctime,path.getatime,path.samefile,path.sameopenfile.All of these functions are tested.