FWIW There are two locations that call .erase_from_bucket, and they both set m_try_shrink_on_next_insert = true;. So I moved that assignment directly into the function.

I expanded the README.md paragraph a bit to add a broader discussion of performance pitfalls. People seem to run into the case #1 regularly because of bad hash functions, so I think it might be worth pointing out more specifically what can go wrong.

By the way: alternatives to erase_it could be:

• erase_iterator
• erase_fast or
• remove

Just a few ideas.

Thank you for this!

Minor comments:

• As another alternative name, I was thinking of erase_void. Your erase_fast would also suit me. erase_it is maybe not explicit enough?
• Would it be possible to add in robin_map/set an API description of the erase_it method? As the reason of this method may not be intuitive;
• Regarding the bad hash performance pitfall, there's a mention at the start of the README:

Four classes are provided: tsl::robin_map, tsl::robin_set, tsl::robin_pg_map and tsl::robin_pg_set. The first two are faster and use a power of two growth policy, the last two use a prime growth policy instead and are able to cope better with a poor hash function. Use the prime version if there is a chance of repeating patterns in the lower bits of your hash (e.g. you are storing pointers with an identity hash function). See GrowthPolicy for details.

But being more explicit with a dedicated section may be good.

I renamed the function to erase_fast and added documentation to the headers.

Regarding the other point: looking back through the issue tracker history, a number of people seem to have run into performance pitfalls, so I think it is useful to spell out in more detail what can go wrong in a worst-case scenario.

If these changes are acceptable to you, it would be great to merge them and declare a new minor version (1.3.0).

Looks good, thanks! I merged the changes and will check to create a release later today.

Awesome, thank you!

Change included in the latest release: https://github.com/Tessil/robin-map/releases/tag/v1.3.0

Hooray! Thank you for including this change, it makes my life much easier :).