Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New argument to force full processing, even when CUDA is not available. #177

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jfcarr
Copy link

@jfcarr jfcarr commented Mar 13, 2022

No description provided.

@zarc70
Copy link

zarc70 commented Mar 14, 2022

Thanks, this got RealESRGAN to work with my GFPGAn for the first time ever!!!

One thing, for me, at least, as written it will not force ESRGAN, but if you change line 62 to True then it will work. Was that the intent? (Also, I had to get rid of Else BG_Upsampler=none, but I might have an older inference file)

@jfcarr
Copy link
Author

jfcarr commented Mar 15, 2022

Thanks, this got RealESRGAN to work with my GFPGAn for the first time ever!!!

One thing, for me, at least, as written it will not force ESRGAN, but if you change line 62 to True then it will work. Was that the intent? (Also, I had to get rid of Else BG_Upsampler=none, but I might have an older inference file)

You shouldn't need to make that change on line 62? If you make a call to inference_gfpgan.py and include the --force_esrgan argument, e.g.:

sudo python3 inference_gfpgan.py -i ./inputs --force_esrgan

Then execution will fall through to the else:, and bg_upsampler will be assigned an instance of RealESRGANer.

@zarc70
Copy link

zarc70 commented Mar 15, 2022

That makes sense to me now and you are absolutely 100% correct. I was trying to make it default to use ESRGAN all the time without using an argument. That was especially lazy of me since I usually use a .bin and could just have added it there. Sorry for the confusion.

@jfcarr
Copy link
Author

jfcarr commented Mar 15, 2022

That makes sense to me now and you are absolutely 100% correct. I was trying to make it default to use ESRGAN all the time without using an argument. That was especially lazy of me since I usually use a .bin and could just have added it there. Sorry for the confusion.

No worries! Glad we got it straightened out.

@benjaminbrumbaugh
Copy link

This should be merged

Copy link

@raja562 raja562 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants