TST: Add tests and document whats_new.rst

TamChen · Oct 16, 2014 · 13c2b00 · 13c2b00
1 parent 5e1faef
commit 13c2b00
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/doc/whats_new.rst b/doc/whats_new.rst
@@ -154,6 +154,10 @@ API changes summary
       ``precompute="auto"`` is now deprecated and will be removed in 0.18
       By `Manoj Kumar`_.
 
+    - Expose ``positive`` option in :func:`linear_model.enet_path` and
+      :func:`linear_model.enet_path` which constrains coefficients to be
+      positive. By `Manoj Kumar`_.
+
 .. _changes_0_15_2:
 
 0.15.2

diff --git a/sklearn/linear_model/tests/test_coordinate_descent.py b/sklearn/linear_model/tests/test_coordinate_descent.py
@@ -21,7 +21,7 @@
 
 from sklearn.linear_model.coordinate_descent import Lasso, \
     LassoCV, ElasticNet, ElasticNetCV, MultiTaskLasso, MultiTaskElasticNet, \
-    MultiTaskElasticNetCV, MultiTaskLassoCV, lasso_path
+    MultiTaskElasticNetCV, MultiTaskLassoCV, lasso_path, enet_path
 from sklearn.linear_model import LassoLarsCV, lars_path
 
 
@@ -574,6 +574,17 @@ def test_deprection_precompute_enet():
     assert_warns(DeprecationWarning, clf.fit, X, y)
 
 
+def test_enet_path_positive():
+    """
+    Test that the coefs returned by positive=True in enet_path are positive
+    """
+
+    X, y, _, _ = build_dataset(n_samples=50, n_features=50)
+    for path in [enet_path, lasso_path]:
+        pos_path_coef = path(X, y, positive=True)[1]
+        assert_true(np.all(pos_path_coef >= 0))
+
+
 if __name__ == '__main__':
     import nose
     nose.runmodule()