[FEATURE] Respect ContainerInterface in StandardVariableProvider #1002
Conversation
|
Resolves #1001 |
composer.json
Outdated
| @@ -10,7 10,8 @@ | |||
| "license": ["LGPL-3.0-or-later"], | |||
| "require": { | |||
| "php": "^8.2", | |||
| "ext-mbstring": "*" | |||
| "ext-mbstring": "*", | |||
| "psr/container": "^2.0" | |||
There was a problem hiding this comment.
Not sure about this dependency. I don't think it's necessary for the code to work, is it?
There was a problem hiding this comment.
No it's not necessary for the instanceof check. However, phpstan will fail if the interface is not present. Therefore I would suggest to add it as dev dependency.
Side note: psr/container is already present in fluid because it's a dependency of symfony/service-contracts, which is required by symfony/console, which is required by friendsofphp/php-cs-fixer.
|
I like the change overall. Sure, it's special handling for one specific kind of object, but it's a PSR standard after all and it can make life easier without much downside. (and I think I would classify this as a feature) |
o-ba
changed the title
|
late comment on this: i think its fine to have the psr/container depedency since i'm pretty sure we'll add functionality based on it at least within view helper invoker soon, anyways. |
No description provided.