Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update VerifiableCredentialBuilder #400

Open
andresuribe87 opened this issue May 30, 2023 · 5 comments
Open

Update VerifiableCredentialBuilder #400

andresuribe87 opened this issue May 30, 2023 · 5 comments
Assignees
@m-rit
Labels
credentials help wanted Extra attention is needed
Milestone
Milestone v0.0

Comments

@andresuribe87
Copy link
Contributor

The spec states that id is optional. If present, it must be a URL, which may be dereferenced.

To better support the spec, we should update the sdk such that:

  • The default ID is empty (to foster stronger privacy).
  • Update the method SetID(), so it does validation that the parameter is a URI (using the url.Parse function).
@decentralgabe
Copy link
Member

Example id values include UUIDs (urn:uuid:0c07c1ce-57cb-41af-bef2-1b932b986873), HTTP URLs (https://id.example/things#123), and DIDs (did:example:1234abcd).

since we use UUIDs we'll probably want to update to add the urn:uuid prefix

@decentralgabe decentralgabe added this to the Milestone v0.0 milestone May 30, 2023
@decentralgabe decentralgabe added the help wanted Extra attention is needed label Jun 12, 2023
@m-rit
Copy link
Contributor

m-rit commented May 30, 2024 •
edited
Loading

@decentralgabe, can I work on a PR to to add this fix if no one is working on it? I've used this repo for a personal projects and I'd like to contribute to the issues.

@decentralgabe
Copy link
Member

@m-rit yes definitely

most of the work at TBD has moved to https://github.com/TBD54566975/web5-go, though I still use this SDK sometimes

@m-rit m-rit mentioned this issue Jun 5, 2024
Merged
@m-rit
Copy link
Contributor

m-rit commented Jun 5, 2024

I have raised a PR to address the issue, NewVerifiableCredentialBuilder now creates VC with empty ID. Should I add an option argument in the function to aupport VC creation with new uuid (the original behaviour) ?

@decentralgabe
Copy link
Member

@m-rit yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m-rit m-rit

Labels
credentials help wanted Extra attention is needed
Projects
No open projects
SSI
Status: 📋 Backlog
Milestone
Milestone v0.0
Development

No branches or pull requests
3 participants
@andresuribe87 @decentralgabe @m-rit