Fix: handle empty /proc/[PID]/cmdline properly
#104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some rare cases, the file /proc/[PID]/cmdline might be empty. This cause nvtop display wrong information about command being executed or even leak some data inside current memory.
|
I'm not very sure that whether |
|
Hi, |
Yes, that patch do resolve this issue and I think it's a better fix than mine. |
|
Merged into master, you're welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some rare cases, the file
/proc/[PID]/cmdlinemight be empty. This causes nvtop display wrong information about command being executed or even leak some data inside current memory.For example, it might leak something similar to
/etc/passwd.I'm not sure how htop or ps handle this kind of case, but I think it's OK to display nothing in command section as it's actually empty there.