[Feature:Developer] Excessive welcome message #10552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the welcome message will only be sent once to each new user
ZheyuDeng
changed the title
micpap25
requested changes
Jun 20, 2024
| id: check-comments | ||
| run: | | ||
| ISSUE_NUMBER=${{ github.event.issue.number }} | ||
| BOT_COMMENT_EXISTS=$(gh issue view "$ISSUE_NUMBER" --json comments --jq '.comments[].body' | grep -q "Hi @$USERNAME," && echo "true" || echo "false") |
There was a problem hiding this comment.
My command line is giving me issues with parsing the single quote on the jq expression. Are you certain this works?
There was a problem hiding this comment.
I ran it in my wsl and also wrote a test file I think it is working fine. You can also check my repo/Create a repo and replace the .github/workflows/first_issue_reply.yml file with the one in this PR and see if it works.
Below is my test file and result:
As you can see it checks if the user "testing-github-actionn" get the welcome message which returned true at the bottom of the second sreeenshot. This test file went through ZheyuDeng#5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10544
What is the current behavior?
Welcome message can be sent multple time to same user in a issue which can be pretty annouying for first time contributor
See the comment section in this issue for reference
#10475
What is the new behavior?
Welcome message will only be sent at most once to each user.
See ZheyuDeng#4