Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting to paket #136

Merged
merged 8 commits into from
Nov 1, 2014
Merged

Converting to paket #136

merged 8 commits into from
Nov 1, 2014

Conversation

forki
Copy link
Contributor

@forki forki commented Nov 1, 2014

Please don't merge. will need to tweak some things

@haf
Copy link
Contributor

haf commented Nov 1, 2014

Fair enough. Remember to run rake to verify the full build works. Right now (with this code) it's throwing TypeLoadException on the tests.

@forki
Copy link
Contributor Author

forki commented Nov 1, 2014

yes. I need to figure out how to restore in albacore...

@forki
Copy link
Contributor Author

forki commented Nov 1, 2014

https://github.com/Albacore/albacore/wiki/Exec doesn't work for me.

PS D:\code\suave> bundle exec rake
DL is deprecated, please use Fiddle
rake aborted!
TypeError: no implicit conversion of Symbol into String
D:/code/suave/Rakefile:19:in `exec'
D:/code/suave/Rakefile:19:in `<top (required)>'
(See full trace by running task with --trace)

//cc @agross

@haf
Copy link
Contributor

haf commented Nov 1, 2014

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

That is v1. Use #system.

On November 1, 2014 2:26:33 PM CET, Steffen Forkmann [email protected] wrote:

https://github.com/Albacore/albacore/wiki/Exec doesn't work for me.

PS D:\code\suave> bundle exec rake
DL is deprecated, please use Fiddle
rake aborted!
TypeError: no implicit conversion of Symbol into String
D:/code/suave/Rakefile:19:in exec' D:/code/suave/Rakefile:19:in<top (required)>'
(See full trace by running task with --trace)

//cc @agross


Reply to this email directly or view it on GitHub:
#136 (comment)


Sent from my Android device with K-9 Mail. Please excuse my brevity.
-----BEGIN PGP SIGNATURE-----
Version: APG v1.1.1

iQI BAEBCgAoBQJUVN/YIRxIZW5yaWsgRmVsZHQgPGhlbnJpa0Bsb2dpYml0LnNl
PgAKCRB9FjoG5k92Rf8QEACSZWf/eSDuO8eD5wH2SqqFyYW0EocDMiU7LVsJgHQI
OcFbA2MGVcnlaS9l6QgHGowuaMAShgWR5LJVAb7wahu 2DSVuw aiO fHI5IRTKy
HPfc1M6AtKTNOjSFtEuEsAnjXQ hKnr KAk Po8WaoXbcwp2Bk1RWsBoPfxna55I
aoZZm9gXhqth c0CruplrcjOAAmarfygtAFOs VZdzWmaPjOmhHVilyRl0QxNsbB
6uV4ApO4GswxFGzrJzH9yVnxvNxFCW70Q70YMncnOerld7hd0hVmq W3O83S bnt
k1FjUH5iqR4ZM8xFFRWsaXDua1CQYjUoEICiV zlO5YiwSyia9ypJekrs124GZ/h
0VURzQ m4AmGeIGqnTh0wC5y dzydLk6/dj6pdzbCocYJZI eON9hmXVoHgrkpnj
mGunIFjzaRdwaiilw7k etalDgUfnOOe882TkZ7MOsgUt04W7oLEMwOZFDml3ZAT
dIN9eMuurMg0DznZ2H4XW8jVIt6A3OPImQnAHX6hosK4Sfo70pn5DfEDM3BTKdcy
0i2pKQ286ndatxl3OsHDW qqUFKJac5HB1qSBGjgBJCjYAbA09MnPTWB6FOYlpsJ
2LZnA7VhARnWqJSHp0jWFrnJIOv81uAdfX IIzlxl9F7NeKHKUV7OM/7CzqZduf
hw==
=XrKi
-----END PGP SIGNATURE-----

@forki
Copy link
Contributor Author

forki commented Nov 1, 2014

looks better now

@haf
Copy link
Contributor

haf commented Nov 1, 2014

Paket version 0.11.10.0
Paket failed with:
   paket.lock doesn't exist.
rake aborted!
Albacore::CommandFailedError: Command failed with status (1):
  mono tools/paket.exe restore
Paket version 0.11.10.0
Paket failed with:
   paket.lock doesn't exist.

Another point: you need to use system like this to cross-platform behaviour (since we don't know that it needs to be run using mono)

desc "Restore paket.exe"
task :restorepakettool do
  system 'tools/paket.bootstrapper.exe', clr_command: true
end

desc "Restore all packages"
task :restore => [:restorepakettool] do
  system 'tools/paket.exe', 'restore', clr_command: true
end

@forki
Copy link
Contributor Author

forki commented Nov 1, 2014

I just saw you gitignored the lockfile. probably because auf the gemlock.

I now commited the lockfile

@forki forki changed the title WIP: Converting to paket Converting to paket Nov 1, 2014
@haf haf merged commit 9ed00e9 into SuaveIO:master Nov 1, 2014
haf added a commit that referenced this pull request Nov 1, 2014
@haf
Copy link
Contributor

haf commented Nov 1, 2014

Thank you @forki ! Awesome!

@forki forki deleted the Paket branch November 1, 2014 14:59
@forki
Copy link
Contributor Author

forki commented Nov 1, 2014

is the appveyor fail expected?

@haf
Copy link
Contributor

haf commented Nov 1, 2014

Yes, it's faulty. I don't have login access to AppVeyor /ping @ademar

@haf
Copy link
Contributor

haf commented Nov 1, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants