fix: type safe db access

StarpTech · May 30, 2021 · fa869df · fa869df
1 parent f1b3dcb
commit fa869df
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/src/registry/maintanance/garbage-collect.ts b/src/registry/maintanance/garbage-collect.ts
@@ -1,6  1,7 @@
 import S from 'fluent-json-schema'
 import { FastifyInstance, FastifySchema } from 'fastify'
 import { SchemaDBModel } from '../../core/models/schemaModel'
 import { SchemaTagDBModel } from '../../core/models/schemaTagModel'
 
 export interface RequestContext {
   Body: {
@@ -33,21  34,21 @@ export default function garbageCollect(fastify: FastifyInstance) {
     return fastify.knex.transaction(async function (trx) {
       const schemasToKeep = await trx
         .from(`${SchemaDBModel.table}`)
-        .orderBy('updatedAt', 'desc')
         .orderBy(SchemaDBModel.field('updatedAt'), 'desc')
         .limit(req.body.numSchemasKeep)
 
       const deletedSchemaTags = await trx
-        .from('schema_tag')
         .from(`${SchemaTagDBModel.table}`)
         .whereNotIn(
-          `schema_tag.schemaId`,
           `${SchemaTagDBModel.field('schemaId')}`,
           schemasToKeep.map((s) => s.id),
         )
         .delete()
 
       const deletedSchemas = await trx
-        .from('schema')
         .from(`${SchemaDBModel.table}`)
         .whereNotIn(
-          `schema.id`,
           `${SchemaDBModel.field('id')}`,
           schemasToKeep.map((s) => s.id),
         )
         .delete()