improve headless provisioning of SELKS on docker #421
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markuskont
force-pushed
the
next-docker-vagrant-2022-10
branch
2 times, most recently
from
11a6bac
to
36ba3b1
Compare
markuskont
force-pushed
the
next-docker-vagrant-2022-10
branch
from
36ba3b1
to
34a7326
Compare
Docker -ti expects a interactive terminal to be left open. That is missing in automated provisioning, such as Vagrantfile scripts. This patch detects missing terminal and adjust docker run flags accordingly.
markuskont
force-pushed
the
next-docker-vagrant-2022-10
branch
from
34a7326
to
fc1170d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-tidocker flag that breaks in such env