Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document zeroconf based authentication properly #955

Merged
merged 3 commits into from
Sep 6, 2022

Conversation

eladyn
Copy link
Member

@eladyn eladyn commented May 16, 2021

In order to be able to use zeroconf based authentication, it is currently necessary to omit everything related to username or password in the configuration.

AFAICT, this is not really documented anywhere except for this wiki entry, which does barely go into details about this. Maybe I just haven't looked in the right places for this, but several others (#938, #948) seem to have trouble finding anything as well.

@stale
Copy link

stale bot commented Aug 14, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Issues that will not be fixed under any circumstances label Aug 14, 2021
@eladyn eladyn force-pushed the zeroconf_auth_docs branch from 97782ad to b3da0c0 Compare August 17, 2021 07:26
@stale stale bot removed the wontfix Issues that will not be fixed under any circumstances label Aug 17, 2021
@eladyn eladyn force-pushed the zeroconf_auth_docs branch from b3da0c0 to aa5271b Compare August 17, 2021 07:30
@eladyn
Copy link
Member Author

eladyn commented Aug 17, 2021

I rebased this PR on the latest master. It would be great to get some feedback on this! 😃

@tomodachi
Copy link
Contributor

Yes plz merge.

Just enabled this and It works great 👍🏽

Nice find @eladyn
Much better than running my hackish solution of running multiple spotifyd daemons with different users on the same device.

@stale
Copy link

stale bot commented Nov 17, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Issues that will not be fixed under any circumstances label Nov 17, 2021
@eladyn
Copy link
Member Author

eladyn commented Nov 18, 2021

Still relevant (I think).

@stale stale bot removed the wontfix Issues that will not be fixed under any circumstances label Nov 18, 2021
@mas-4
Copy link

mas-4 commented Nov 19, 2021

@eladyn I commented in the relevant issue (#948) and will repeat here: it seems you also need to have caching disabled for this to work. When cache_directory is set in the configuration the credentials of the first user to connect are cached and then anyone else who tries to connect causes the program to restart (using a systemd service with restart=always restartsec=12). It might be worth adding that to the documentation. It might be worth seeing if adding a "no_credential_caching" option to config is useful. I'm not a contributor to this project so just asking.

@eladyn
Copy link
Member Author

eladyn commented Nov 20, 2021

@mas-4 Thanks for investigating this! I added a small note about the caching behaviour. It would be great if you could check whether this fits with your findings.

As for the no_credential_caching thing, I will add my thoughts on this in the linked issue.

@mas-4
Copy link

mas-4 commented Nov 20, 2021

@eladyn I actually had cache_directory set which was also the problem. Might be worth noting both parameters.

@eladyn
Copy link
Member Author

eladyn commented Nov 20, 2021

I currently can't find any mention of cache_directory, neither in the docs nor in the actual code. But it surely doesn't hurt to add it.

@slondr slondr added the pinned Apply to make stale bot ignore issue/PR. label Jan 14, 2022
@SimonTeixidor
Copy link
Member

Thanks!

@SimonTeixidor SimonTeixidor merged commit 7146f64 into Spotifyd:master Sep 6, 2022
@eladyn eladyn deleted the zeroconf_auth_docs branch September 8, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinned Apply to make stale bot ignore issue/PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants